running-apps: update running-apps to use Duration.ago() (#182172)

jwren · web-flow · commit 7ff0723e08fd · 2026-02-23T16:36:21.000Z
Cleanup from #180098 #182155
diff --git a/packages/flutter_tools/lib/src/commands/running_apps.dart b/packages/flutter_tools/lib/src/commands/running_apps.dart
@@ -107,7 +107,10 @@ class RunningAppsCommand extends FlutterCommand {
       final String deviceId = app.deviceId;
       final String platform = app.targetPlatform;
       final String vmServiceUri = app.wsUri;
-      final String age = processAge(app.epoch, _systemClock);
+      final String age = _systemClock
+          .now()
+          .difference(DateTime.fromMillisecondsSinceEpoch(app.epoch))
+          .ago();
 
       // If the device name and ID are effectively the same (e.g., "macos" and "macos"),
       // only show the name to avoid redundancy like "macos (macos)".
@@ -151,24 +154,3 @@ class RunningAppsCommand extends FlutterCommand {
     }
   }
 }
-
-/// Formats the elapsed time since the given epoch.
-@visibleForTesting
-String processAge(int? epoch, SystemClock systemClock) {
-  // TODO(jwren): Consider using [DurationAgo] from `lib/src/base/utils.dart`.
-  // We need to decide on the width and precision, possibly modifying the utility
-  // to support a shorter form (e.g. "5m" versus "5 minutes ago").
-  if (epoch == null) {
-    return 'unknown age';
-  }
-  final Duration elapsed = systemClock.now().difference(DateTime.fromMillisecondsSinceEpoch(epoch));
-  if (elapsed.inDays > 0) {
-    return '${elapsed.inDays}d';
-  } else if (elapsed.inHours > 0) {
-    return '${elapsed.inHours}h';
-  } else if (elapsed.inMinutes > 0) {
-    return '${elapsed.inMinutes}m';
-  } else {
-    return '${elapsed.inSeconds}s';
-  }
-}
diff --git a/packages/flutter_tools/test/commands.shard/hermetic/running_apps_test.dart b/packages/flutter_tools/test/commands.shard/hermetic/running_apps_test.dart
@@ -10,7 +10,6 @@ import 'package:flutter_tools/src/commands/running_apps.dart';
 import 'package:multicast_dns/multicast_dns.dart';
 import 'package:test/fake.dart';
 
-import '../../src/common.dart';
 import '../../src/context.dart';
 import '../../src/test_flutter_command_runner.dart';
 
@@ -194,11 +193,15 @@ dart_version=2.0.0''',
     // Verify formatting - 2 spaces indent, bullet separator
     expect(
       testLogger.statusText,
-      contains('  app_one (debug)   • macos  • darwin-arm64   • ws://127.0.0.1:1234/ws • 1s'),
+      contains(
+        '  app_one (debug)   • macos  • darwin-arm64   • ws://127.0.0.1:1234/ws • 0 minutes ago',
+      ),
     );
     expect(
       testLogger.statusText,
-      contains('  app_two (release) • chrome • web-javascript • ws://127.0.0.1:5678/ws • 2s'),
+      contains(
+        '  app_two (release) • chrome • web-javascript • ws://127.0.0.1:5678/ws • 0 minutes ago',
+      ),
     );
   });
 
@@ -330,41 +333,6 @@ dart_version=2.0.0''',
     expect('app_one'.allMatches(testLogger.statusText), hasLength(1));
     expect(testLogger.statusText, contains('ws://127.0.0.1:1234/ws'));
   });
-
-  testWithoutContext('processAge', () {
-    const kSecondMs = 1000;
-    const int kMinuteMs = kSecondMs * 60;
-    const int kHourMs = kMinuteMs * 60;
-    const int kDayMs = kHourMs * 24;
-
-    const kNowMs = 10_000_000;
-    const int kFiveSecondsMs = 5 * kSecondMs;
-    const int kFiftyNineSecondsMs = 59 * kSecondMs;
-    const int kFiftyNineMinutesMs = 59 * kMinuteMs;
-    const int kTwentyThreeHoursMs = 23 * kHourMs;
-    const int kTwoDaysMs = 2 * kDayMs;
-
-    final now = DateTime.fromMillisecondsSinceEpoch(kNowMs);
-    final clock = SystemClock.fixed(now);
-
-    expect(processAge(null, clock), 'unknown age');
-
-    // Seconds
-    expect(processAge(kNowMs - kFiveSecondsMs, clock), '5s');
-    expect(processAge(kNowMs - kFiftyNineSecondsMs, clock), '59s');
-
-    // Minutes
-    expect(processAge(kNowMs - kMinuteMs, clock), '1m');
-    expect(processAge(kNowMs - kFiftyNineMinutesMs, clock), '59m');
-
-    // Hours
-    expect(processAge(kNowMs - kHourMs, clock), '1h');
-    expect(processAge(kNowMs - kTwentyThreeHoursMs, clock), '23h');
-
-    // Days
-    expect(processAge(kNowMs - kDayMs, clock), '1d');
-    expect(processAge(kNowMs - kTwoDaysMs, clock), '2d');
-  });
 }
 
 class FakeMDnsClient extends Fake implements MDnsClient {
