[Impeller] Silence bugprone-unchecked-optional-access in renderer_golden_unittests

bdero · bdero · commit 1ba148f1866b · 2026-05-20T03:25:56.000-07:00
clang-tidy does not recognise gtest's ASSERT_TRUE as flow-affecting, so
desc-&gt; accesses after ASSERT_TRUE(desc.has_value()) trip
bugprone-unchecked-optional-access. Use the same NOLINTBEGIN/NOLINTEND
block as renderer_unittests.cc, referencing the same tracking issue.
diff --git a/engine/src/flutter/impeller/renderer/renderer_golden_unittests.cc b/engine/src/flutter/impeller/renderer/renderer_golden_unittests.cc
@@ -21,6 +21,9 @@
 #include "impeller/renderer/render_pass.h"
 #include "impeller/renderer/vertex_buffer_builder.h"
 
+// TODO(zanderso): https://github.com/flutter/flutter/issues/127701
+// NOLINTBEGIN(bugprone-unchecked-optional-access)
+
 namespace impeller {
 namespace testing {
 
@@ -81,4 +84,6 @@ TEST_P(RendererGoldenTest, BabysFirstTriangle) {
 }  // namespace testing
 }  // namespace impeller
 
+// NOLINTEND(bugprone-unchecked-optional-access)
+
 #endif  // IMPELLER_GOLDEN_TESTS
