This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Check for null response_handle in FlutterEngineSendPlatformMessage #9697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR flutter#9655 allows for providing a response handle when sending messages into the Flutter engine, but didn't check for a null response handle; this crashes all existing embedders that use FlutterEngineSendPlatformMessage.
Contributor
|
My bad. Thanks. I'll add a unit-test for this. |
chinmaygarde
approved these changes
Jul 6, 2019
Contributor
|
#9698 pulls in this patch and adds a unit-test for the same. |
Contributor
Author
|
Closing in favor of the more complete patch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #9655 allows for providing a response handle when sending messages
into the Flutter engine, but didn't check for a null response handle;
this crashes all existing embedders that use
FlutterEngineSendPlatformMessage.