This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove SkToBool usage. #4326
Closed
Remove SkToBool usage. #4326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkToBool only existed as a workaround for the MSVC++ warning C4800 about conversion to bool. Unfortunately, it is now incompatible with the new clang warning -Wzero-as-null-pointer-constant. Since C4800 has been removed from from the newer MSVC++ compilers, Skia would like to remove this poorly cased define.
chinmaygarde
approved these changes
Nov 6, 2017
Contributor
|
@bungeman Can you run clang-format as per the Travis error and resubmit? Then we can land it. Thanks! |
Merged
Contributor
|
Abandoned in favor of #4429. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SkToBool only existed as a workaround for the MSVC++ warning C4800 about conversion to bool. Unfortunately, it is now incompatible with the new clang warning -Wzero-as-null-pointer-constant. Since C4800 has been removed from from the newer MSVC++ compilers, Skia would like to remove this poorly cased define.