-
Notifications
You must be signed in to change notification settings - Fork 6k
Support DisposalMethod::kRestorePrevious in MultiFrameCodec and fix the apng problem. #42153
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
% ../../flutter_macos_3.10.1-stable/flutter/bin/flutter doctor -v [!] Flutter (Channel stable, 3.10.1, on macOS 13.2.1 22D68 darwin-x64, locale zh-Hans-CN) |
|
Here is the problem video 3.10 exists: apng_problem.mp4Here is the problem example: |
This reverts commit ee97ded.
bdero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM w\ nit about naming.
|
after a more efficient solution apng_ok.mp4 |
bdero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
Support DisposalMethod::kRestorePrevious in MultiFrameCodec and fix the apng problem.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.