Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Apr 14, 2023

This builder doesn't use or install jazzy or Xcode, remove the properties from the config.

Passing without these properties: https://ci.chromium.org/p/flutter/builders/try/Mac%20impeller-cmake-example/14

@jmagman jmagman self-assigned this Apr 14, 2023
@jmagman jmagman marked this pull request as ready for review April 14, 2023 21:22
@jmagman jmagman requested a review from zanderso April 14, 2023 21:22
cpu: arm64
config_name: mac_impeller_cmake_example
$flutter/osx_sdk : >-
{ "sdk_version": "14a5294e" }
Copy link
Member

@zanderso zanderso Apr 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It uses the macOS SDK: https://github.com/flutter/engine/blob/main/ci/builders/mac_impeller_cmake_example.json#L17. Will that still be there? You can try this change in presubmit by temporarily commenting out bringup: true.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, the builders inherit dimensions from their orchestrator? That's unexpected...
It doesn't seem to be inheriting the dependencies. https://ci.chromium.org/p/flutter/builders/staging/Mac%20Staging%20Engine%20Drone/87661

This is the first time I've played with the v2 stuff.
Trying with bringup to see what happens.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure. I say let's try this change in presubmit, and if it works, let's ship it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 15, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Apr 15, 2023

auto label is removed for flutter/engine, pr: 41222, due to - The status or check suite Mac Host clang-tidy has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 15, 2023
@zanderso zanderso merged commit 1c60032 into flutter:main Apr 15, 2023
@jmagman jmagman deleted the impeller-cmake branch April 17, 2023 19:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants