-
Notifications
You must be signed in to change notification settings - Fork 6k
Remove jazzy and Xcode properties from impeller-cmake-example builder #41222
Conversation
| cpu: arm64 | ||
| config_name: mac_impeller_cmake_example | ||
| $flutter/osx_sdk : >- | ||
| { "sdk_version": "14a5294e" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It uses the macOS SDK: https://github.com/flutter/engine/blob/main/ci/builders/mac_impeller_cmake_example.json#L17. Will that still be there? You can try this change in presubmit by temporarily commenting out bringup: true.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, the builders inherit dimensions from their orchestrator? That's unexpected...
It doesn't seem to be inheriting the dependencies. https://ci.chromium.org/p/flutter/builders/staging/Mac%20Staging%20Engine%20Drone/87661
This is the first time I've played with the v2 stuff.
Trying with bringup to see what happens.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure. I say let's try this change in presubmit, and if it works, let's ship it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
auto label is removed for flutter/engine, pr: 41222, due to - The status or check suite Mac Host clang-tidy has failed. Please fix the issues identified (or deflake) before re-applying this label. |
This builder doesn't use or install jazzy or Xcode, remove the properties from the config.
Passing without these properties: https://ci.chromium.org/p/flutter/builders/try/Mac%20impeller-cmake-example/14