This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Make PathComponent POD, allow querying specific component type counts #40605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
commented
Mar 24, 2023
Comment on lines
+174
to
+176
| static_assert(!std::is_polymorphic<LinearPathComponent>::value); | ||
| static_assert(!std::is_polymorphic<QuadraticPathComponent>::value); | ||
| static_assert(!std::is_polymorphic<CubicPathComponent>::value); |
Contributor
Author
There was a problem hiding this comment.
This is my "test" that these stay POD.
Member
There was a problem hiding this comment.
Ooh nice, I didn't know this was a thing.
Contributor
Author
There was a problem hiding this comment.
I was going to add some asserts about the sizes but this is better
bdero
approved these changes
Mar 24, 2023
Comment on lines
+174
to
+176
| static_assert(!std::is_polymorphic<LinearPathComponent>::value); | ||
| static_assert(!std::is_polymorphic<QuadraticPathComponent>::value); | ||
| static_assert(!std::is_polymorphic<CubicPathComponent>::value); |
Member
There was a problem hiding this comment.
Ooh nice, I didn't know this was a thing.
Member
|
I think this needs a rebase to resolve the build failure. |
Member
|
Actually there might be a caching problem on the bots flutter/flutter#123416 |
Contributor
|
auto label is removed for flutter/engine, pr: 40605, due to - The status or check suite Mac Unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I manually verified that this does not regress #39124
This will make these things a bit easier to use in compute (I can just memcpy them). Also makes them take a little less memory which is nice?