Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Isolate platform channels macos refactor #36157

Closed
gaaclarke wants to merge 5 commits into from
Closed

Isolate platform channels macos refactor #36157

gaaclarke wants to merge 5 commits into from

Conversation

@gaaclarke
Copy link
Member

@gaaclarke gaaclarke commented Sep 14, 2022 •
edited
Loading

testing refactor of #35893

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gaaclarke gaaclarke force-pushed the isolate-platform-channels-macos-refactor branch from 5762a88 to 231e461 Compare September 15, 2022 00:17
@gaaclarke gaaclarke force-pushed the isolate-platform-channels-macos-refactor branch from 231e461 to 7e2af03 Compare September 15, 2022 00:31
@gaaclarke gaaclarke mentioned this pull request Sep 15, 2022
Merged
8 tasks
@Hixie
Copy link
Contributor

Hixie commented Dec 7, 2022

@gaaclarke is this PR still on your radar?

@gaaclarke
Copy link
Member Author

gaaclarke commented Dec 7, 2022

This was just a test, we can close it out.

@gaaclarke gaaclarke closed this Dec 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

embedder Related to the embedder API platform-android platform-ios

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gaaclarke @Hixie