This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[impeller] Fix offset calculation in vertex attribute pointers. #33184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Labeling will only be enabled when the GL_KHR_debug extension is present (it usually is).
We build up the offset as we iterate over stage inputs. But the order of binding locations is not the same as iteration order. This causes the inputs to be bound to the wrong locations. In the case of stroke rendering, vertex normals were being assigned to the coordinate locations and vice-versa. Also fixes text rendering a whole lot more test cases.
Contributor
Author
|
Builds on top of a couple of other patches in the queue. Only the final commit is new. Text and stroke rendering now works with OpenGLES 2! I believe only offscreen rendering is left. On it now. |
bdero
approved these changes
May 6, 2022
Contributor
Author
|
Made obsolete by #33223. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We build up the offset as we iterate over stage inputs. But the order
of binding locations is not the same as iteration order. This causes
the inputs to be bound to the wrong locations. In the case of stroke
rendering, vertex normals were being assigned to the coordinate
locations and vice-versa.
Also fixes text rendering a whole lot more test cases.