Fix windows keyboard: Extended key, delegate order by dkwingsmt · Pull Request #26757 · flutter-team-archive/engine

dkwingsmt · 2021-06-15T09:40:40Z

This PR fixes Windows's keyboard implementation by:

The channel handler now adds 0xE000 to extended keys, matching Chromium's setting.
- This should fix Skip the window key (both left and right) on Windows flutter/flutter#84292. Without 0xE000 being set, the physical key for MetaLeft is not recognized and thus converted to none, which somehow messes up the following backspace events.
FlutterWindowsView now adds the embedder handler before the channel handler.
- This is unrelated to Skip the window key (both left and right) on Windows flutter/flutter#84292.
- A test is added.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.
The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

gspencergoog

gspencergoog · 2021-06-15T19:53:36Z

 // emitting a warning on the console about unhandled events.
 static constexpr int kMaxPendingEvents = 1000;

+// Chromium uses this bit in scancode to mark "extended" keys.


Are you saying "Chromium" here because that's where you saw this pattern, or does this have something to do with Chromium on Windows running Flutter code? (I imagine it can only be the first, but the comment is unclear).

fluttergithubbot · 2021-06-16T22:54:01Z

This pull request is not suitable for automatic merging in its current state.

The status or check suite build_and_test_linux_unopt_debug has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite licenses_check has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Prebuild ci/docker/build/Dockerfile has failed. Please fix the issues identified (or deflake) before re-applying this label.

…eam-archive/engine#26757)

* 7e449ce Roll Skia from fab6ede2ec1d to 33da72d168d7 (24 revisions) (flutter-team-archive/engine#26790) * 9d2ab41 Fix windows keyboard: Extended key, delegate order (flutter-team-archive/engine#26757) * e3f4f2b Roll Dart SDK from 2084c5eeef79 to 914b1c6d1c88 (4 revisions) (flutter-team-archive/engine#26792) * 4754a23 Roll Skia from 33da72d168d7 to 491282486e34 (1 revision) (flutter-team-archive/engine#26793) * 6a7f1a9 Roll Skia from 491282486e34 to b2cb817d23d0 (4 revisions) (flutter-team-archive/engine#26795) * 42d391d Fix a leak of the resource EGL context on Android (flutter-team-archive/engine#26789) * 4f89b26 Roll Dart SDK from 914b1c6d1c88 to 369366069b83 (1 revision) (flutter-team-archive/engine#26799) * 6e9444b Roll Skia from b2cb817d23d0 to e8502cc73c5d (5 revisions) (flutter-team-archive/engine#26801) * 86dacc0 Revert "Support scrolling in iOS accessibility (#26671)" (flutter-team-archive/engine#26803) * 0cbaa80 Disable Skia reduceOpsTaskSplitting option (flutter-team-archive/engine#26568) * b9761b2 Roll Skia from e8502cc73c5d to 8e814b3be082 (6 revisions) (flutter-team-archive/engine#26805) * e274d31 Remove autoninja calls from the analyze script. (flutter-team-archive/engine#26752) * 399917c Revert "Remove autoninja calls from the analyze script. (#26752)" (flutter-team-archive/engine#26812) * b9616ca Roll Dart SDK from 369366069b83 to 0796dd6c7bcf (1 revision) (flutter-team-archive/engine#26807)

…eam-archive/engine#26757)

…ive#26757) * Adjust order * Update code * Fix Extended * Add tests * Better constants * Format * Comment * Link

au-top · 2021-06-23T02:59:04Z

It has a certain effect! Thank you for your contribution! But I found that the problem still exists. I still can't delete it after using Win + space in the flutter. I need to press win again in the flutter program to fix this phenomenon!

Only textfield is needed to reproduce


Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel master, 2.3.0-17.0.pre.397, on Microsoft Windows [Version 10.0.17763.1999], locale zh-CN)
[!] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    X cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    X Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/windows#android-setup for more details.
[√] Chrome - develop for the web
[√] Visual Studio - develop for Windows (Visual Studio Enterprise 2019 16.9.0)
[√] Android Studio (version 4.1.0)
[√] IntelliJ IDEA Community Edition (version 2021.1)
[√] VS Code
[√] VS Code, 64-bit edition (version 1.56.2)
[√] Connected device (2 available)

! Doctor found issues in 1 category.

RPRX · 2021-06-23T16:33:57Z

@au-top Upgrade 到最新 master channel 即可，2.3.0-17.0.pre.397 还不包含修复了问题的 flutter engine。

au-top · 2021-06-24T01:23:31Z

@au-top Upgrade 到最新 master channel 即可，2.3.0-17.0.pre.397 还不包含修复了问题的 flutter engine。

好的谢谢!

…ive#26757) * Adjust order * Update code * Fix Extended * Add tests * Better constants * Format * Comment * Link

dkwingsmt added 7 commits June 11, 2021 04:55

Adjust order

f959132

Update code

83ccdf8

Fix Extended

382257d

Add tests

36e85a7

Better constants

728fb14

Merge remote-tracking branch 'upstream/master' into win-key

d7ef56f

Format

4ef3044

flutter-dashboard Bot added the platform-windows label Jun 15, 2021

google-cla Bot added the cla: yes label Jun 15, 2021

dkwingsmt requested a review from gspencergoog June 15, 2021 11:43

dkwingsmt mentioned this pull request Jun 15, 2021

Skip the window key (both left and right) on Windows flutter/flutter#84292

Closed

gspencergoog approved these changes Jun 15, 2021

View reviewed changes

dkwingsmt added 2 commits June 15, 2021 23:20

Comment

dc93c03

Link

8201ddf

dkwingsmt added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jun 16, 2021

fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jun 16, 2021

Merge remote-tracking branch 'upstream/master' into win-key

f673631

dkwingsmt merged commit 9d2ab41 into flutter-team-archive:master Jun 17, 2021

dkwingsmt deleted the win-key branch June 17, 2021 12:00

engine-flutter-autoroll mentioned this pull request Jun 17, 2021

Roll Engine from ced58ef9c13e to 9d2ab4142cf7 (2 revisions) flutter/flutter#84777

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2021

9d2ab41 Fix windows keyboard: Extended key, delegate order (flutter-t…

f91d018

…eam-archive/engine#26757)

engine-flutter-autoroll mentioned this pull request Jun 17, 2021

Roll Engine from ced58ef9c13e to e3f4f2b68b37 (3 revisions) flutter/flutter#84780

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2021

9d2ab41 Fix windows keyboard: Extended key, delegate order (flutter-t…

14f88bd

…eam-archive/engine#26757)

engine-flutter-autoroll mentioned this pull request Jun 17, 2021

Roll Engine from ced58ef9c13e to 4754a23d1640 (4 revisions) flutter/flutter#84783

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2021

9d2ab41 Fix windows keyboard: Extended key, delegate order (flutter-t…

cfdc0ab

…eam-archive/engine#26757)

engine-flutter-autoroll mentioned this pull request Jun 17, 2021

Roll Engine from ced58ef9c13e to 42d391d7bbcc (6 revisions) flutter/flutter#84790

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2021

9d2ab41 Fix windows keyboard: Extended key, delegate order (flutter-t…

876c32d

…eam-archive/engine#26757)

engine-flutter-autoroll mentioned this pull request Jun 17, 2021

Roll Engine from ced58ef9c13e to 4f89b26e9417 (7 revisions) flutter/flutter#84800

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2021

9d2ab41 Fix windows keyboard: Extended key, delegate order (flutter-t…

78e580f

…eam-archive/engine#26757)

engine-flutter-autoroll mentioned this pull request Jun 17, 2021

Roll Engine from ced58ef9c13e to 86dacc0aad71 (9 revisions) flutter/flutter#84805

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2021

9d2ab41 Fix windows keyboard: Extended key, delegate order (flutter-t…

261580d

…eam-archive/engine#26757)

engine-flutter-autoroll mentioned this pull request Jun 18, 2021

Roll Engine from ced58ef9c13e to b9616cad9c7d (14 revisions) flutter/flutter#84882

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 18, 2021

9d2ab41 Fix windows keyboard: Extended key, delegate order (flutter-t…

5ac981e

…eam-archive/engine#26757)

engine-flutter-autoroll mentioned this pull request Jun 20, 2021

Roll Engine from ced58ef9c13e to 1eb8a34a3975 (46 revisions) flutter/flutter#84949

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 20, 2021

9d2ab41 Fix windows keyboard: Extended key, delegate order (flutter-t…

24ebb66

…eam-archive/engine#26757)

wqyfavor pushed a commit to wqyfavor/engine that referenced this pull request Jun 21, 2021

Fix windows keyboard: Extended key, delegate order (flutter-team-arch…

2b09eca

…ive#26757) * Adjust order * Update code * Fix Extended * Add tests * Better constants * Format * Comment * Link

RPRX mentioned this pull request Jun 25, 2021

[Windows][Desktop]: Unable to delete text using backspace, tab key also not working. flutter/flutter#84583

Closed

tgucio mentioned this pull request Jul 9, 2021

Windows: Dead keys are not producing accented characters flutter/flutter#86179

Closed

dkwingsmt added the affects: text input label Jul 30, 2021

naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request Sep 2, 2021

Fix windows keyboard: Extended key, delegate order (flutter-team-arch…

94cdc98

…ive#26757) * Adjust order * Update code * Fix Extended * Add tests * Better constants * Format * Comment * Link

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix windows keyboard: Extended key, delegate order#26757

Fix windows keyboard: Extended key, delegate order#26757
dkwingsmt merged 10 commits into
flutter-team-archive:masterfrom
dkwingsmt:win-key

dkwingsmt commented Jun 15, 2021 •

edited

Loading

Uh oh!

gspencergoog left a comment

Uh oh!

Uh oh!

gspencergoog Jun 15, 2021

Uh oh!

fluttergithubbot commented Jun 16, 2021

Uh oh!

au-top commented Jun 23, 2021 •

edited

Loading

Uh oh!

RPRX commented Jun 23, 2021

Uh oh!

au-top commented Jun 24, 2021

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

dkwingsmt commented Jun 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

gspencergoog left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gspencergoog Jun 15, 2021

Choose a reason for hiding this comment

Uh oh!

fluttergithubbot commented Jun 16, 2021

Uh oh!

au-top commented Jun 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RPRX commented Jun 23, 2021

Uh oh!

au-top commented Jun 24, 2021

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

5 participants

dkwingsmt commented Jun 15, 2021 •

edited

Loading

au-top commented Jun 23, 2021 •

edited

Loading