Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] Wrap all the contents of the glass-pane in a shadow root. #25483

Closed
ditman wants to merge 14 commits into from
Closed

[web] Wrap all the contents of the glass-pane in a shadow root. #25483

ditman wants to merge 14 commits into from

Conversation

@ditman
Copy link
Member

@ditman ditman commented Apr 7, 2021

This is a WIP review, just to trigger CI and see all the breakage that a change like this would cause.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Apr 7, 2021
@google-cla google-cla bot added the cla: yes label Apr 7, 2021
yjbanov
yjbanov reviewed Apr 13, 2021
View reviewed changes
lib/web_ui/test/engine/semantics/semantics_test.dart
// found in the LICENSE file.

// @dart = 2.6
// @dart = 2.9
Copy link
Contributor

@yjbanov yjbanov Apr 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be 2.12 at this point?

Copy link
Member Author

@ditman ditman Apr 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.12 only if we migrate the test to null-safety, which this is not doing yet :P

@ditman ditman requested a review from yjbanov April 14, 2021 19:30
@ditman ditman changed the title [WIP] Wrap all the contents of the glass-pane in a shadow root. [web] Wrap all the contents of the glass-pane in a shadow root. Apr 14, 2021
@ditman
Copy link
Member Author

ditman commented Apr 15, 2021

I just realized that I regressed rendering the RulerHosts into the new ShadowDOM. Oops.

@ditman ditman mentioned this pull request Apr 15, 2021
Closed
6 tasks
ditman added 14 commits April 21, 2021 14:40
@ditman
Wrap all the contents of the glass-pane in a shadow root.
d3e3235
@ditman
Make analyzer happy
b8a4bf8
@ditman
Tweak semantics_test so it is shadow-DOM aware.
176c362
@ditman
Render all text_editing primitives inside the new shadow root.
37b513f
@ditman
Tweak text_editing_test so it is shadow-DOM aware.
0ae928a
@ditman
dartfmt -w .
da351ec
@ditman
Do not select flt-glass-pane all the time. Reuse the reference inside .
fe0cb88
@ditman
Don't mess with the dart version in tests
16703f7
@ditman
Revert fanciness
615d9e1
@ditman
Ensure the glass-pane and its shadow root exist before testing.
65d9535
@ditman
Make dom_renderer_test shadow-root aware.
32b5f7a
@ditman
Do not use flt-glass-pane selectors across the code. Expose the shado…
b896350 
…w root from domRenderer.
@ditman
Make canvas_golden_test shadow-DOM aware.
554821b
@ditman
Add a root Node parameter to text measurement, and pass the correct o…
9675bad 
…ne when the domRenderer is initializing.
@ditman ditman mentioned this pull request Apr 24, 2021
Merged
9 tasks
@ditman
Copy link
Member Author

ditman commented Apr 27, 2021

Continued in #25747

@ditman ditman closed this Apr 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@yjbanov yjbanov Awaiting requested review from yjbanov

Assignees

No one assigned

Labels

cla: yes platform-web Code specifically for the web engine

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ditman @yjbanov