This repository was archived by the owner on Feb 25, 2025. It is now read-only.
fix paddingTop for full-screen mode #17748
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for the patch. Can you add a test in FlutterViewTest.java? With Robolectric and Mockito, you should be able to mock both the input and output. See https://github.com/flutter/engine/blob/master/shell/platform/android/test/io/flutter/embedding/android/FlutterViewTest.java#L51 for example. You can mock a FlutterRenderer and assert that setViewportMetrics is called with the correct number for both status bar hidden and not hidden cases. |
Member
|
I patched your PR in #17985 so closing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix padding top issue for full-screen mode. Related to: flutter/flutter#54911