Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e4e274898efc
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: eaf73cd39cf8
Choose a head ref
  • 6 commits
  • 31 files changed
  • 5 contributors

Commits on Apr 9, 2024

  1. Roll Skia from a86861d21ae1 to 74b0e26886f0 (2 revisions) (#52000) 

    https://skia.googlesource.com/skia.git/+log/a86861d21ae1..74b0e26886f0

2024-04-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 57a0fe0778df to fc7b9c1b84df (4 revisions)
2024-04-09 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from f51ecbb7b732 to aae22bdd5489 (17 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Apr 9, 2024
    Configuration menu
    Copy the full SHA
    31365e7 View commit details
    Browse the repository at this point in the history

  2. [Impeller] Remove stencil clipping logic. (#51999) 

    Follow-up for #51992.

This is now dead code.
    @bdero
    bdero authored Apr 9, 2024
    Configuration menu
    Copy the full SHA
    d9e38b1 View commit details
    Browse the repository at this point in the history

  3. Try postsubmit_overrides for one mac build (#51676)

    @zanderso
    zanderso authored Apr 9, 2024
    Configuration menu
    Copy the full SHA
    364fbc4 View commit details
    Browse the repository at this point in the history

  4. Roll Skia from 74b0e26886f0 to 45eeeddb0074 (1 revision) (#52007) 

    https://skia.googlesource.com/skia.git/+log/74b0e26886f0..45eeeddb0074

2024-04-09 bungeman@google.com [pdf] Allow OpenType CFF fonts to be embedded

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Apr 9, 2024
    Configuration menu
    Copy the full SHA
    e23ca36 View commit details
    Browse the repository at this point in the history

  5. [Impeller] Refactor KHR swapchains to make it easy to reuse backend a… 

    …gnostic components. (#52002)

Just a refactor to make room for the AHB swapchains implementation while also ensuring that the MSAA and depth-stencil transients memoization as well as the existing surface implementation can be reused by that swapchain backend.

This does a few major things:

* Make an abstract implementation of swapchains, SwapchainVK. This currently has KHRSwapchainVK as its sole subclass but will soon have AHBSwapchainVK.
* There is no more per swapchain backend memoization of the MSAA and depth-stencil textures. This is now moved to SwapchainTransientsVK and can be shared by both backend. This leads into the next change. This also avoids the round trip of the textures first being set on each swapchain image and then accessed to create the onscreen renderpass. Now the transients can access the textures directly. 
* KHRSurfaceVK no longer wraps a KHRSwapchainImageVK. Instead, it deals with TextureSourceVKs (which used to be the base class of KHRSwapchainImageVK). This surface can now magically work with AHBTextureSourceVK since they have a common base class. Since the surface is now backend agnostic, it has been renamed to SurfaceVK.

There is one minor functional change over the previous implementation thought. Earlier, the transients would be created and cached when the swapchain was resized. Now, the same will happen when the first surface frame is attempted to be acquired at the new size. This effectively means that swapchain resized should be faster and do less work if no frames are rendered at the new size (continuous window resized maybe).
    @chinmaygarde
    chinmaygarde authored Apr 9, 2024
    Configuration menu
    Copy the full SHA
    8dd3ba8 View commit details
    Browse the repository at this point in the history

  6. Update embedder example apps to run with the current engine tree (#51995 

    )

* Update ICU data paths for the move of third_party/icu out of the buildroot
* Link with -rdynamic to enable lookup of Dart resource symbols within the app executables
* Use Material 3 text styles that are supported by the current Flutter framework
    @jason-simmons
    jason-simmons authored Apr 9, 2024
    Configuration menu
    Copy the full SHA
    eaf73cd View commit details
    Browse the repository at this point in the history
Loading