Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: d623ecf43c66
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 51e643de62aa
Choose a head ref
  • 5 commits
  • 25 files changed
  • 5 contributors

Commits on Sep 15, 2023

  1. Roll Fuchsia Linux SDK from ES0r-mYplPOBYHvUQ... to wWzXsy6kx1sp8Km34… 

    …... (#45879)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Sep 15, 2023
    Configuration menu
    Copy the full SHA
    09034a7 View commit details
    Browse the repository at this point in the history

  2. [Impeller] Introduce mock vulkan context builder (#45834) 

    This allows us to have better control over the mock context and allows us to test situations like having the validations available, versus not available.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @gaaclarke
    gaaclarke authored Sep 15, 2023
    Configuration menu
    Copy the full SHA
    bd765e9 View commit details
    Browse the repository at this point in the history

  3. Migrate GrMipmapped->skgpu::Mipmapped (#45881) 

    Skia's Graphite and Ganesh backend coalesced two enums regarding mipmaps
into one and deprecated the public Ganesh version. This migrates Flutter
to use the preferred type.

No functional changes expected. See also
https://skia-review.googlesource.com/c/skia/+/753567

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
    @kjlubick
    kjlubick authored Sep 15, 2023
    Configuration menu
    Copy the full SHA
    1c9e4f6 View commit details
    Browse the repository at this point in the history

  4. Update AGP and Kotlin for scenario app (#45549) 

    flutter/flutter/#134220

Command required to update lock files required not using the custom task and required matching the version of gradle in ci and passing a custom version of java. 
`~/.gradle/wrapper/dists/gradle-7.5.1-bin/7jzzequgds1hbszbhq3npc5ng/gradle-7.5.1/bin/gradle -D=org.gradle.java.home=/Library/Java/JavaVirtualMachines/zulu-11.jdk/Contents/Home  app:dependencies --write-locks` for app:dependencies and dependencies.
    @reidbaker
    reidbaker authored Sep 15, 2023
    Configuration menu
    Copy the full SHA
    40383fe View commit details
    Browse the repository at this point in the history

  5. Adds a --quiet flag to run_tests.py (#45880) 

    This PR changes run_tests.py to use the python logging library to report
results instead of direct prints or writes to stdout/stderr. This change
simplifies adding a `--quiet` flag that causes the script to only
generate output if a log is emitted at WARNING or above.

Overall this is a bit of progress toward landing something like
#45595
    @zanderso
    zanderso authored Sep 15, 2023
    Configuration menu
    Copy the full SHA
    51e643d View commit details
    Browse the repository at this point in the history
Loading