Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: d21bb634e054
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2440ad6d39a5
Choose a head ref
  • 8 commits
  • 36 files changed
  • 6 contributors

Commits on Nov 6, 2020

  1. Rasterizer is initialized with an external view embedder (#22348) 

    This allows us to not rely on surface methods for getting
the external view embedder.
    @iskakaushik
    iskakaushik authored Nov 6, 2020
    Configuration menu
    Copy the full SHA
    0d5f2e9 View commit details
    Browse the repository at this point in the history

  2. Ignore several import_of_legacy_library_into_null_safe (#22326)

    @scheglov
    scheglov authored Nov 6, 2020
    Configuration menu
    Copy the full SHA
    cf37614 View commit details
    Browse the repository at this point in the history

  3. Roll Skia from ba9a04f to 4eb7c23 (4 revisions) (#22355)

    @skia-flutter-autoroll
    skia-flutter-autoroll authored Nov 6, 2020
    Configuration menu
    Copy the full SHA
    b0a2ed6 View commit details
    Browse the repository at this point in the history

  4. Do not involve external_view_embedder in submit frame process if thre… 

    …ads are not merged. (#22275)
    Chris Yang authored Nov 6, 2020
    Configuration menu
    Copy the full SHA
    016fbde View commit details
    Browse the repository at this point in the history

  5. Roll Skia from 4eb7c23 to b8123cc (6 revisions) (#22358)

    @skia-flutter-autoroll
    skia-flutter-autoroll authored Nov 6, 2020
    Configuration menu
    Copy the full SHA
    a52a1f8 View commit details
    Browse the repository at this point in the history

  6. [web] Split the EngineParagraph interface from the legacy implementat… 

    …ion (#22307)
    @mdebbar
    mdebbar authored Nov 6, 2020
    Configuration menu
    Copy the full SHA
    d3c0727 View commit details
    Browse the repository at this point in the history

  7. Use dispatchKeyEvent, and handle keys sent to InputConnection.sendKey… 

    …Event on Android (#22340)

This (mostly) re-lands #21163, which was reverted in #22321

This switches from using onKeyDown to using dispatchKeyEvent on Android so that keys can be intercepted handled by the framework and not continue to be dispatched to other controls.

It also now intercepts key events sent to InputConnection.sendKeyEvent, as some IMEs do (e.g. the Hacker's Keyboard), and sends them to Flutter.

This fixes the problem where (for example) pressing TAB on a hardware keyboard sends the tab to both the text field and to the focus traversal system.

Note that we still can't intercept all keystrokes given to a soft keyboard, only those which the soft keyboard decides to send to InputConnection.sendKeyEvent, and system keys (like the back button) are only received if the IME doesn't eat them.
    @gspencergoog
    gspencergoog authored Nov 6, 2020
    Configuration menu
    Copy the full SHA
    13a624a View commit details
    Browse the repository at this point in the history

  8. Roll Skia from b8123cc to e886b8e (7 revisions) (#22361)

    @skia-flutter-autoroll
    skia-flutter-autoroll authored Nov 6, 2020
    Configuration menu
    Copy the full SHA
    2440ad6 View commit details
    Browse the repository at this point in the history
Loading