Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: bcb281cde579
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 8e19915c19fc
Choose a head ref
  • 4 commits
  • 13 files changed
  • 4 contributors

Commits on Nov 7, 2024

  1. [skwasm] Make sure to include the transfer list when using postMessag… 

    …e. (#56431)

This change doesn't have unit tests, because it doesn't actually change the functional behavior of the renderer, it only changes its performance characteristics. If the transfer list is not included, the browser copies the image bitmaps instead of transfers them, which is slow, but does actually work. I am going to be adding some additional benchmarking in the framework to ensure that we detect if we regress something like this again.
    @eyebrowsoffire
    eyebrowsoffire authored Nov 7, 2024
    Configuration menu
    Copy the full SHA
    a2ada9a View commit details
    Browse the repository at this point in the history

  2. iOS: Eliminate ScopedBlock, ScopedTypeRef, ScopedPolicy (#56410) 

    Eliminates the two remaining uses of ScopedBlock and with it, ScopedTypeRef which was only used by ScopedBlock. ARC automatically generates the necessary block copy/retain/release calls, including moving blocks to the heap during a retain so manual _Block_copy/_Block_release calls are no longer required.

No test changes since no semantic changes.

Issue: flutter/flutter#137801

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @cbracken
    cbracken authored Nov 7, 2024
    Configuration menu
    Copy the full SHA
    d132ada View commit details
    Browse the repository at this point in the history

  3. [Impeller] Use Matrix::MakeTranslateScale to compute the source-to-de… 

    …stination mapping in DrawImageRect (#56433)
    @jason-simmons
    jason-simmons authored Nov 7, 2024
    Configuration menu
    Copy the full SHA
    e4aaac6 View commit details
    Browse the repository at this point in the history

  4. Roll Skia from e9a7546ef3d9 to 2ed9606702f1 (1 revision) (#56434) 

    https://skia.googlesource.com/skia.git/+log/e9a7546ef3d9..2ed9606702f1

2024-11-07 jvanverth@google.com [graphite] Add scratch label when returning Resources to ResourceCache

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,kjlubick@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Nov 7, 2024
    Configuration menu
    Copy the full SHA
    8e19915 View commit details
    Browse the repository at this point in the history
Loading