Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: a8890fdccd66
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cf0fbadcec3a
Choose a head ref
  • 2 commits
  • 3 files changed
  • 2 contributors

Commits on Sep 21, 2018

  1. Remove bottom safe-area padding when keyboard up (#6297) 

    On the iPhone X, raising the keyboard sets a bottom physical inset equal
to the keyboard height, however we previously did not zero out the bottom
physical padding. This was incorrect; when a soft keyboard is present,
it 'consumes' the safe area inset for the home indicator widget,
eliminating the need for the app to handle this at all.
    @cbracken
    cbracken authored Sep 21, 2018
    Configuration menu
    Copy the full SHA
    2ec20aa View commit details
    Browse the repository at this point in the history

  2. Roll src/third_party/skia 44c6167..05cf051 (4 commits) (#6299) 

    https://skia.googlesource.com/skia.git/+log/44c6167c4125..05cf051f0252


Created with:
  gclient setdep -r src/third_party/skia@05cf051f0252

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Sep 21, 2018
    Configuration menu
    Copy the full SHA
    cf0fbad View commit details
    Browse the repository at this point in the history
Loading