Commits on May 25, 2023

1. [Rasterizer] Make resubmit information temporary (#42001) …

   This PR refactors `Rasterizer` so that the resubmit information is
   returned as a temporary struct instead of stored permanently as class
   member. This limits the lifetime of these values and reduces class
   members.
   
   Additionally, this benefits the multi-view project: if the rasterizer is
   going to store multiple surfaces, what variables should be stored in a
   map from view IDs? Should all surfaces have a to-be-submitted record?
   The answer is "no", because these information is only temporary.
   
   This PR should not need unit tests since it's only a refactor.
   
   ## Pre-launch Checklist
   
   - [ ] I read the [Contributor Guide] and followed the process outlined
   there for submitting PRs.
   - [ ] I read the [Tree Hygiene] wiki page, which explains my
   responsibilities.
   - [ ] I read and followed the [Flutter Style Guide] and the [C++,
   Objective-C, Java style guides].
   - [ ] I listed at least one issue that this PR fixes in the description
   above.
   - [ ] I added new tests to check the change I am making or feature I am
   adding, or Hixie said the PR is test-exempt. See [testing the engine]
   for instructions on writing and running engine tests.
   - [ ] I updated/added relevant documentation (doc comments with `///`).
   - [ ] I signed the [CLA].
   - [ ] All existing and new tests are passing.
   
   If you need help, consider asking for advice on the #hackers-new channel
   on [Discord].
   
   <!-- Links -->
   [Contributor Guide]:
   https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
   [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
   [Flutter Style Guide]:
   https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
   [C++, Objective-C, Java style guides]:
   https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
   [testing the engine]:
   https://github.com/flutter/flutter/wiki/Testing-the-engine
   [CLA]: https://cla.developers.google.com/
   [flutter/tests]: https://github.com/flutter/tests
   [breaking change policy]:
   https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
   [Discord]: https://github.com/flutter/flutter/wiki/Chat

   

   dkwingsmt authored May 25, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 9f36408
   • Browse repository at this point

   Copy the full SHA

   9f36408 View commit details

   Browse the repository at this point in the history

2. Roll Skia from e648bf802cd2 to bd677c195886 (2 revisions) (#42325) …

   https://skia.googlesource.com/skia.git/+log/e648bf802cd2..bd677c195886
   
   2023-05-25 kjlubick@google.com Make test tags configurable
   2023-05-25 michaelludwig@google.com [skif] Fix required input recursion for Runtime image filters
   
   If this roll has caused a breakage, revert this CL and stop the roller
   using the controls here:
   https://autoroll.skia.org/r/skia-flutter-autoroll
   Please CC bdero@google.com,brianosman@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
   is aware of the problem.
   
   To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
   To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
   
   To report a problem with the AutoRoller itself, please file a bug:
   https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
   
   Documentation for the AutoRoller is here:
   https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

   

   skia-flutter-autoroll authored May 25, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 6a4e675
   • Browse repository at this point

   Copy the full SHA

   6a4e675 View commit details

   Browse the repository at this point in the history