Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 971ddd9fe1bf
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 23ceae6de46f
Choose a head ref
  • 3 commits
  • 19 files changed
  • 2 contributors

Commits on Aug 15, 2024

  1. [Impeller] convert aiks blur tests to new canvas. (#54565) 

    Part of DL interop. Currently experiencing some ... issues with blur radius/sigma.
EDIT: was rrect_blur vs gaussian: fixed now.

Part of flutter/flutter#142054

Reland because of CI issue?
    Jonah Williams authored Aug 15, 2024
    Configuration menu
    Copy the full SHA
    e783ec6 View commit details
    Browse the repository at this point in the history

  2. [Impeller] Switch from AIKS canvas to DL based canvas implementation. (… 

    …#53781)

The first part of switching Impeller/Aiks to using the display list instead of re-recording rendering operations. This should eventually let us cut CPU overhead of the raster thread for complex applications, though it should have no impact on GPU performance.

This does introduce a GLES only rendering bug that I haven't had luck tracking down, but is almost certainly due to switching to DL computed depth values. I'd like to handle this as a follow up when we prioritize GLES. flutter/flutter#153504

Part of flutter/flutter#142054
    Jonah Williams authored Aug 15, 2024
    Configuration menu
    Copy the full SHA
    f2c7fcf View commit details
    Browse the repository at this point in the history

  3. Update RBE troubleshooting (#54568) 

    Add `could not get valid Application Default Credentials token` troubleshooting
    @jtmcdole
    jtmcdole authored Aug 15, 2024
    Configuration menu
    Copy the full SHA
    23ceae6 View commit details
    Browse the repository at this point in the history
Loading