Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 6cefbe183546
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 67713071563e
Choose a head ref
  • 5 commits
  • 10 files changed
  • 4 contributors

Commits on Mar 11, 2024

  1. [gn] Change sdk_rewriter() template to use depfiles (#51314) 

    Part of flutter/flutter#144430

From `gn help inputs`: "It may be tempting to write a script that enumerates all files in a directory
as inputs. Don't do this!"
    @zanderso
    zanderso authored Mar 11, 2024
    Configuration menu
    Copy the full SHA
    eac124e View commit details
    Browse the repository at this point in the history

  2. Make scenario app have translucent splash screen so it doesn't affect… 

    … screenshot colors (#51329)

Makes the scenario app splash screen have a translucent color, so it doesn't end up overlaying on screenshots.

Before:
[device-2024-03-07-152047.webm](https://github.com/flutter/flutter/assets/34871572/a9b7a1f9-57ab-4eda-93e5-5ca70032cbef)

After:
[translucentsplash.webm](https://github.com/flutter/engine/assets/34871572/a6eb6407-add0-4004-83f9-4e0a5c1bb6f6)

This sort of fixes flutter/flutter#144657? The issue is still odd to me, though, because I don't know why the test runner wouldn't be waiting properly for the splash screen.

Bonus, this is what it looks like if we [change the runner](https://github.com/flutter/engine/blob/b178aa5848dca0d7a50b408762399eda7282555a/testing/scenario_app/bin/run_android_tests.dart#L352) to not use animations, with `--no-window-animation` (but don't include the splash screen change):
[no_animation_example.webm](https://github.com/flutter/engine/assets/34871572/0c8665a3-b546-4bbd-b7e1-00851c48e1ff)
You can see there is still a moment of color change at the end of tests (ignore the very first test I was alt tabbing and lagged out my emulator).

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @gmackall
    gmackall authored Mar 11, 2024
    Configuration menu
    Copy the full SHA
    4e717c2 View commit details
    Browse the repository at this point in the history

  3. Roll Skia from 6f10903e2d28 to 32f1cb50734a (5 revisions) (#51331) 

    https://skia.googlesource.com/skia.git/+log/6f10903e2d28..32f1cb50734a

2024-03-11 brianosman@google.com Change Slug drawing to accept a paint at draw-time
2024-03-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f5ef6971f8fb to 51c9e2056611 (1 revision)
2024-03-11 johnstiles@google.com Fix ClangTidy readability-redundant-control-flow warning.
2024-03-11 jvanverth@google.com [graphite] Add zero-sized path handling to new RasterPathAtlas method.
2024-03-11 briansalomon@gmail.com [graphite] Support mipmap filtering for YUVA Images

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Mar 11, 2024
    Configuration menu
    Copy the full SHA
    aa702f8 View commit details
    Browse the repository at this point in the history

  4. Roll Dart SDK from 09a1a1ede1c4 to 7a2c94fd0a26 (1 revision) (#51338) 

    https://dart.googlesource.com/sdk.git/+log/09a1a1ede1c4..7a2c94fd0a26

2024-03-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-222.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Mar 11, 2024
    Configuration menu
    Copy the full SHA
    70e7751 View commit details
    Browse the repository at this point in the history

  5. [web] Split initialization of the _flutter namespace and loader objec… 

    …t. (#51294)

This makes it possible to more flexibly compose `{{flutter_js}}` and `{{flutter_build_options}}` in @eyebrowsoffire's [bootstrapping improvements PR](flutter/flutter#144434).

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @ditman
    ditman authored Mar 11, 2024
    Configuration menu
    Copy the full SHA
    6771307 View commit details
    Browse the repository at this point in the history
Loading