Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 48d7b04674d9
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0ac9e97cc1c0
Choose a head ref
  • 2 commits
  • 7 files changed
  • 2 contributors

Commits on Aug 20, 2024

  1. Roll Skia from ada9a367c5f2 to cc9c81d7fc4d (1 revision) (#54641) 

    https://skia.googlesource.com/skia.git/+log/ada9a367c5f2..cc9c81d7fc4d

2024-08-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 579a58552fa6 to 1a191b1d5dc8 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Aug 20, 2024
    Configuration menu
    Copy the full SHA
    cf7399f View commit details
    Browse the repository at this point in the history

  2. Check return values for Sk[I]Rect::intersect (#54577) 

    The `SkRect::intersect` and `SkIRect::intersect` methods return values that must be handled or the calling code might end up with a non-empty answer for non-intersecting rectangles. There were 3 or 4 places in our code that we weren't doing this so now we check them all, in some cases even if we believe that the answer will not be empty.

This is prep work so that Skia can add `[[nodiscard]]` directives to these 2 methods so that nobody else makes that mistake.
    @flar
    flar authored Aug 20, 2024
    Configuration menu
    Copy the full SHA
    0ac9e97 View commit details
    Browse the repository at this point in the history
Loading