Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2d55e29dfa79
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2159fdb8461d
Choose a head ref
  • 8 commits
  • 13 files changed
  • 4 contributors

Commits on Oct 16, 2023

  1. Roll Skia from 85c8dca08cbe to 8919fecf15c1 (1 revision) (#46966)

    https://skia.googlesource.com/skia.git/+log/85c8dca08cbe..8919fecf15c1
    
    2023-10-16 kjlubick@google.com Reland "Remove GL dependency from GrBackendSemaphore"
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC brianosman@google.com,jsimmons@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored Oct 16, 2023
    Configuration menu
    Copy the full SHA
    2692787 View commit details
    Browse the repository at this point in the history
  2. Fix Platform.script for flutter_tester (#46911)

    This addresses the problem in flutter/flutter#12847 which changed slightly over time.
    
    Today, `Platform.script` does not give an empty `file` URI, it gives something like `file://path/to/package/main.dart` _regardless of how the file is actually named_.
    
    After this change, it will give the absolute path to the file being run under test.
    
    So before this change, the new test would have a URI like
    
    ```
    file:///Users/dnfield/src/flutter/engine/src/main.dart
    ```
    
    And now it has
    
    ```
    file:///Users/dnfield/src/flutter/engine/src/out/host_debug_unopt_arm64/gen/platform_test.dart.dill
    ```
    
    This is going to be helpful in generating relative paths from the test file.
    dnfield authored Oct 16, 2023
    Configuration menu
    Copy the full SHA
    b14d346 View commit details
    Browse the repository at this point in the history
  3. [Impeller] GPUTracer for Metal. (#46846)

    Impelement GPU frame time tracing for metal. Unlike Vulkan, this can't use dummy cmd buffers as those don't seem to ever get an executed callback. Instead we decorate every submitted cmd buffer with tracing functionality, and min/max the timestamps to compute the range of computation time.
    Jonah Williams authored Oct 16, 2023
    Configuration menu
    Copy the full SHA
    ade3c05 View commit details
    Browse the repository at this point in the history
  4. Roll Skia from 8919fecf15c1 to 751358929d1f (4 revisions) (#46972)

    https://skia.googlesource.com/skia.git/+log/8919fecf15c1..751358929d1f
    
    2023-10-16 kjlubick@google.com Move SkDebug.cpp from core to base
    2023-10-16 lovisolo@google.com [bazel] Add android_benchmark_test rule and sample targets.
    2023-10-16 lovisolo@google.com [bazel] Move some utilities from //bazel to //tools/testrunners/common.
    2023-10-16 nicolettep@google.com [graphite] Use UBO for intrinsic constant, remove inline uniform support
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC brianosman@google.com,jsimmons@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored Oct 16, 2023
    Configuration menu
    Copy the full SHA
    11db7f3 View commit details
    Browse the repository at this point in the history
  5. Roll Fuchsia Linux SDK from 6E-cSq679DjzBMcqY... to Y9mDBoH4BSC6pWFXV…

    …... (#46974)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
    Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored Oct 16, 2023
    Configuration menu
    Copy the full SHA
    bb9947d View commit details
    Browse the repository at this point in the history
  6. Roll Dart SDK from 12f6559bd6ed to f3e1cd38e8b0 (1 revision) (#46977)

    https://dart.googlesource.com/sdk.git/+log/12f6559bd6ed..f3e1cd38e8b0
    
    2023-10-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-29.0.dev
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/dart-sdk-flutter-engine
    Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored Oct 16, 2023
    Configuration menu
    Copy the full SHA
    1c17ee2 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. Revert "Fix Platform.script for flutter_tester" (#46981)

    This reverts commit b14d346.
    
    With #46911, the Platform.script API will return a URI for the compiled temporary wrapper script generated by "flutter test".  This will cause issues for tests that expect Platform.script to reflect the directory where "flutter test" was launched.
    jason-simmons authored Oct 17, 2023
    Configuration menu
    Copy the full SHA
    5bddd42 View commit details
    Browse the repository at this point in the history
  2. Roll Skia from 751358929d1f to 205b728a8623 (1 revision) (#46982)

    https://skia.googlesource.com/skia.git/+log/751358929d1f..205b728a8623
    
    2023-10-17 johnstiles@google.com Fix issues discovered by ClangTidy 17.
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC brianosman@google.com,jsimmons@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored Oct 17, 2023
    Configuration menu
    Copy the full SHA
    2159fdb View commit details
    Browse the repository at this point in the history
Loading