-
Notifications
You must be signed in to change notification settings - Fork 364
Adding a flag to devtools_tools serve for dtd uri #7191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Actually wait a minute. Since we are already forwarding remaining arguments through to the command to start the DevTools server, I don't think we need to parse this manually from the |
|
@kenzieschmoll without this change i got the following error:
So I figured that adding it here was kind of like allowlisting it |
|
I think we do need this for the same reasons we have things like |
kenzieschmoll
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can you add a TODO to consider using AllowAnythingParser? Would also be good to separate the flags consts that are there to pass through to the DevTools server, and add a comment. (_dtdUriFlag, _machineFlag, _allowEmbeddingFlag) - any flag that we aren't removing later is intended to be passed through.

The devtools server is getting a --dtd-uri flag in https://dart-review.googlesource.com/c/sdk/+/346922
This change allows devtools_tool serve to pass along that flag.