Skip to content

Conversation

@kenzieschmoll
Copy link
Member

@kenzieschmoll kenzieschmoll commented Nov 9, 2023

This changes the build-release command to build and adds arguments:

  • build-mode: this can be one of 'debug', 'profile', or 'release' (defaults to 'release')
  • pub-get: this flag can be negated (--no-pub-get) to prevent devtools_tool pub-get --only-main from being run before building DevTools. This is helpful for faster development cycles when building DevTools with the DevTools server.

This PR also:

  • de-duplicates code between the BuildCommand and ServeCommand classes. Since the majority of the arguments added to the ServeCommand arg parser are just being passed along to the devtools_tool build command.
  • fixes a bug in the update-flutter-sdk script

Copy link
Contributor

@DanTup DanTup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kenzieschmoll kenzieschmoll requested a review from a team as a code owner November 9, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants