Don't reuse embedded windows in launchDevTools #2489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default,
launchDevToolswill try to reuse existing open DevTools instances when told to launch (and show a notification, or reconnect disconnected ones). Embedded windows should be entirely excluded from these, as their windows are managed entirely by the IDE and not launched by DevTools.This updates the
changePagecall to also transmit a whether the page is embedded or not, and the server to ignore any embedded clients when looking for a client to reuse.Fixes Dart-Code/Dart-Code#2931.