Skip to content

Conversation

@DanTup
Copy link
Contributor

@DanTup DanTup commented Jan 21, 2019

VS Code understands pub: build_runner serve as a task now (and has the problemMatcher internally) so we don't need quite so much junk in order to make F5 work when editing this in VS Code.

@devoncarew This shouldn't change any behaviour, and it seems to work ok in my quick testing, though I'm not actually sure if there are any significant differences between calling webdev serve and pub build_runner serve (which is what Dart Code has support for)?

VS Code understands `pub: build_runner serve` as a task now (and has the problemMatcher internally) so we don't need quite so much junk in order to make F5 work when editing this in VS Code.
@devoncarew
Copy link
Contributor

devoncarew commented Jan 21, 2019

though I'm not actually sure if there are any significant differences between calling webdev serve and pub build_runner serve (which is what Dart Code has support for)?

webdev serve is the same as pub build_runner serve (however, we generally want to treat webdev as our entry-point for tooling).

@DanTup
Copy link
Contributor Author

DanTup commented Jan 22, 2019

we generally want to treat webdev as our entry-point for tooling

Is it stable enough that we'd be happy to ship integration with it? Currently we detect build_runner(?) in the pubspec to show the build_runner tasks, it wouldn't be difficult to also detect webdev and show them (presumably we'd want to hide the build_runner ones in that case?).

I'll land this as-is for now, but we can update it when the Dart plugin understands webdev.

@DanTup DanTup merged commit 8bdb0b3 into flutter:master Jan 22, 2019
@DanTup DanTup deleted the simplify-vscode branch January 22, 2019 08:48
@devoncarew
Copy link
Contributor

Is it stable enough that we'd be happy to ship integration with it?

Yes, and more work is being put into it currently.

it wouldn't be difficult to also detect webdev and show them (presumably we'd want to hide the build_runner ones in that case?).

This sounds reasonable; generally I think we want to either only show webdev items, or at least prefer them. My understanding is that build_runner is more on the level of plumbing.

@DanTup
Copy link
Contributor Author

DanTup commented Jan 22, 2019

generally I think we want to either only show webdev items

Will webdev be in the pubspec for projects it's valid for, or can uses pub global activate it? (I need to know which projects it's valid to use for).

My understanding is that build_runner is more on the level of plumbing.

For non-web users (Flutter, CLI) is there some equiv to webdev run the codegen/start watching? (I figured they'd always use build_runner).

@devoncarew
Copy link
Contributor

I think that pub global activate will be the most common way to run it - there may not be much indication in the pubspec that its in use.

For non-web users (Flutter, CLI) is there some equiv to webdev run the codegen/start watching?

I'm not certain here -

@DanTup
Copy link
Contributor Author

DanTup commented Jan 22, 2019

Ok, I've opened Dart-Code/Dart-Code#1412 about changing over - though we'll need to figure out how to identify which projects to use webdev for!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants