-
Notifications
You must be signed in to change notification settings - Fork 364
Closed
Labels
P1high priority issues at the top of the work list, actively being worked on.high priority issues at the top of the work list, actively being worked on.dart2wasm
Description
The DevTools codebase is prepared for building DevTools with dart2wasm thanks to the unblocking work here.
There are still a few requirements that we need to meet before moving this effort forward:
- Land the bootstrapping changes to DevTools in a way that does not break our g3 roll.
- CC @eyebrowsoffire @xster we will need support from the Fl@G team to fully support the new bootstrapping syntax. If adding full support is infeasible right now, we may have to workaround this by diverging the g3 bootstrapping code from the external. This is not ideal since this will cause a continued maintenance burden and potential regressions in g3, given we will not be testing externally with the same bootstrapping used in g3. See b/343786318 for tracking issue.
- Done in Reland migration to use new flutter bootstrapping methods #7865. G3 change to use legacy index.html: cl/638797386.
-
Ensure that the VS Code embedded web views support WasmGC (see background information on Chromium and V8)@DanTup can you confirm?- EDIT: This will only work if the user has set
--enable-coifor VS Code. At this time, this is not something we want to recommend because this may cause performance regressions for VS Code. Until Enable COI for desktop withcredentiallessmicrosoft/vscode#186614 is fixed, we do not expect users using DevTools embedded inside VS Code to be able to use the wasm build. See comments below for more details.
- Ensure that the IntelliJ embedded web views (JXBrowser) support WasmGC (see background information on Chromium and V8)
- @helin24 can you confirm?
- Add support for opt in / opt out behavior. See these web bootstrapping docs for an example of customizing configuration based on query parameters.
- Fixed by Add wasm opt-in setting #8270
- Add support for building DevTools with wasm and serving it from the DevTools server with the proper headers
- Add support for building with Wasm to the recipe running the automated LUCI builds of DevTools. These builds are what ships with the Dart SDK
- Ensure DevTools is shipped with source maps so that crashes from DevTools with wasm are actionable: Get stacktrace information in release build of DevTools #7392
- Ensure analytics reflect whether a user is running DevTools with wasm or not (fixed by Upgrade to unified_analytics 6.1.3 #8317)
Compare the dart2wasm DevTools build to dart2js and file any issues that come up.
Blocking:
kevmoo and iapicca
Metadata
Metadata
Assignees
Labels
P1high priority issues at the top of the work list, actively being worked on.high priority issues at the top of the work list, actively being worked on.dart2wasm