Skip to content

Use Json serializable class for LUCI builders#921

Merged
keyonghan merged 2 commits intoflutter:masterfrom
keyonghan:json_serializable_luci_builder
Aug 21, 2020
Merged

Use Json serializable class for LUCI builders#921
keyonghan merged 2 commits intoflutter:masterfrom
keyonghan:json_serializable_luci_builder

Conversation

@keyonghan
Copy link
Contributor

This is to fix: flutter/flutter#64286

Copy link
Contributor

@godofredoc godofredoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for refactoring, it is a lot more cleaner now. @digiter thanks for suggesting this change.

@keyonghan keyonghan merged commit b4a521a into flutter:master Aug 21, 2020
@keyonghan keyonghan deleted the json_serializable_luci_builder branch March 13, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace non-type-safe Map<String, dynamic> to JsonSeriablizable annotated class when retrieving luci builders

2 participants