Branch dropdown menu on build dashboard #700
Conversation
0bd9606 to
009425e
Compare
|
/cc @Hixie if you have time, can you take a look at this? It's for adding a dropdown to the build dashboard to change branches. I'm running into an issue where I can't get the text color to be white when the dropdown is idle, and have it be black when the dropdown menu is open. |
| value: buildState.currentBranch, | ||
| icon: Icon( | ||
| Icons.arrow_downward, | ||
| color: Colors.white, |
There was a problem hiding this comment.
in theory the color should be picked up automatically by the ambient theme, something like how i made it happen for the SIGN IN button. cc @HansMuller for advice.
There was a problem hiding this comment.
Thanks! I am going to submit on green to enable testing of the branching release strategy. Will follow up with smoothing this out next week.
| child: Text(value, style: TextStyle(color: Colors.black)), | ||
| ); | ||
| }).toList()), | ||
| Container(width: 10), // Padding between branches and sign in |
There was a problem hiding this comment.
SizedBox(width: 10) is more efficient
There was a problem hiding this comment.
Thanks! Added.
|
I'm still learning the codebase, but LGTM. |
This adds a dropdown button to the build dashboard appbar that allows for switching the current branch. It adds updates
FlutterBuildStateto be able to change the branch that data is shown from.It currently erases previous branch data when switching to a new branch.
Open Questions
I feel
moreStatusesExistcan have a better name. I am looking for a variable name that says the build state knows that more commit statuses exist from the backend, and they have to be loaded over the network. In certain cases (such as branches not master), there is only a few commits and Cocoon should not keep trying the infinite load approachIssues
flutter/flutter#51807 - Flutter branching for releases
Tests
Tests for update branch and new behavior.
Widget tests to check the dropdown exists
Preview
https://testchillers-dot-flutter-dashboard.appspot.com/#/build