Skip to content

Explicitly use the master branch in build dashboard #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CaseyHillers merged 5 commits into from
Mar 18, 2020
Merged

Explicitly use the master branch in build dashboard #693

CaseyHillers merged 5 commits into from
Mar 18, 2020

Conversation

@CaseyHillers
Copy link
Contributor

@CaseyHillers CaseyHillers commented Mar 18, 2020 •
edited
Loading

Create currentBranch in FlutterBuildState and plumbed it through everywhere that uses it.

Refactored some of the test code to remove some of the duplication spread throughout it and fixed some spacing issues.

Tests

Added tests for apiEndpoint refactor to handle query parameters.

Updated tests to check for defaulting to the master branch.

Issues

flutter/flutter#51807 - Flutter branching for releases

Future work

Create an updateBranch method in FlutterBuildState to change currentBranch to update the UI.

@keyonghan keyonghan mentioned this pull request Mar 18, 2020
Closed
19 tasks
@CaseyHillers CaseyHillers changed the title Explicitly use the master branch in build state Explicitly use the master branch in build dashboard Mar 18, 2020
digiter
digiter approved these changes Mar 18, 2020
View reviewed changes
Copy link
Contributor

@digiter digiter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit: it seems there's no test with branch name other than "master", consider adding one?

keyonghan
keyonghan reviewed Mar 18, 2020
View reviewed changes
keyonghan
keyonghan approved these changes Mar 18, 2020
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CaseyHillers
Add test for query specific branches
295eb85 
Fix nesting of a group within a group
@CaseyHillers
Copy link
Contributor Author

CaseyHillers commented Mar 18, 2020

Added the test for specific branches. Good catch! Fixed some groups that were nested in another group.

@CaseyHillers CaseyHillers merged commit 041f15f into flutter:master Mar 18, 2020
@CaseyHillers CaseyHillers deleted the master_branch branch March 18, 2020 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@digiter digiter digiter approved these changes

@keyonghan keyonghan keyonghan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CaseyHillers @digiter @keyonghan