Add branch to commit key #684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvolkert
suggested changes
Mar 12, 2020
godofredoc
approved these changes
Mar 13, 2020
Contributor
godofredoc
left a comment
There was a problem hiding this comment.
Let's tell people in the discord and flutter hacker chat about this change when we are ready to roll it.
19 tasks
Contributor
|
Out of an abundance of caution, you may also want to back up the datastore before rolling this out. |
Contributor
Author
|
will do a backup later today. |
Contributor
Author
|
A quick update, I have backed up all datastore entities over the weekend. Am gonna to merge and redeploy. Please let me know if any other concerns or comments. |
Contributor
Author
|
@tvolkert seems your approval is necessary. Could you please help review/comment/approve? Thank you. |
tvolkert
approved these changes
Mar 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves flutter/flutter#52443