Skip to content

Conversation

@CaseyHillers
Copy link
Contributor

@CaseyHillers CaseyHillers commented Mar 5, 2020

Cocoon LUCI task is throwing issues building app_dart. This upgrades the dependencies and any reliances on those dependencies to get it running again.

@CaseyHillers CaseyHillers changed the title pub upgrade Upgrade app_dart dependencies Mar 5, 2020
@CaseyHillers CaseyHillers changed the title Upgrade app_dart dependencies Upgrade Cocoon dependencies Mar 5, 2020
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@CaseyHillers
Copy link
Contributor Author

There's two issues on Flutter dev that Cocoon will have to address
(1) Find a new way of testing that doesn't rely on colors of widgets
(2) NetworkImage changes

To make sure breaking changes like this are not introduced, I'll follow up and see if we can get Cocoon added to flutter/tests so that changes like this have to be sent out as breaking changes.

For now, I am setting Flutter to beta. It was set to dev as web support had not made it to beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants