Made it so dismissed approvals don't block the autosubmit bot.#5025
Conversation
|
Also, not directly related to this change, but I notice that the UI lets me dismiss a REQUESTED_CHANGES review: Does this mean that a REQUESTED_CHANGES review doesn't actually block an author from submitting, because they can always just dismiss that review? So REQUESTED_CHANGES is more of a suggestion than something that is enforceed? Or is this UI something most people don't have, and I just see it because I have elevated permissions? |
The requirement is that you have approval, not that there is no requests changes. Dismissing requests changes should be used respectfully obviously. |
b-luk
left a comment
There was a problem hiding this comment.
This looks good to me, but I have no experience with this code or with how it works. So please also get approval from someone else who is more familiar with this.
| expect(result.result, isTrue); | ||
| }); | ||
|
|
||
| test('COMMENTED review should NOT clear previous CHANGES_REQUESTED', () async { |
There was a problem hiding this comment.
This is testing an impossible scenario, because our graphql query won't return a COMMENTED review. Maybe we can remove this test because it can be misleading.
|
friendly ping @jtmcdole |
|
I tried merging main because |
I suspect GitHub was sick. |
fixes flutter/flutter#185224
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.