Skip to content

Add .gemini/ to test exemption list #4815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Aug 1, 2025
Merged

Add .gemini/ to test exemption list #4815

auto-submit merged 2 commits into from
Aug 1, 2025

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Jul 28, 2025 •
edited
Loading

See flutter/flutter#172887 (comment)

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman marked this pull request as ready for review July 30, 2025 17:50
@jmagman jmagman requested a review from jtmcdole July 30, 2025 17:50
@jmagman jmagman mentioned this pull request Jul 30, 2025
Merged
stuartmorgan-g
stuartmorgan-g approved these changes Jul 30, 2025
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although ideally this should be tested.

@jmagman
Copy link
Member Author

jmagman commented Jul 30, 2025

LGTM, although ideally this should be tested.

Yeah... I usually add tests for these, but I got lazy. You got me.

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App. label Aug 1, 2025
@auto-submit auto-submit bot merged commit 9a9f440 into flutter:main Aug 1, 2025
17 checks passed
@jmagman jmagman deleted the gemini branch August 1, 2025 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@jtmcdole jtmcdole jtmcdole approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmagman @stuartmorgan-g @jtmcdole