Skip engine builds/tests for a framework-only PR (allow-listed) #4185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Adding @yjbanov as a reviewer as well just for a second set of eyes (seeing that I helped with this pr) |
4 tasks
jtmcdole
approved these changes
Jan 27, 2025
| if (pullRequest.user!.login == config.autosubmitBot && | ||
| pullRequest.labels!.any((element) => element.name == Config.revertOfLabel)) { | ||
| log.info('$logCrumb: skipping generating the full set of checks for revert request.'); | ||
| log.info('$logCrumb: skipping generating the full set of checstagest.'); |
Member
There was a problem hiding this comment.
I think this line got vscode-share-ifiied
Contributor
Author
|
I am going to submit, @yjbanov we'll be making more edits to this in the coming days so feedback is still welcome post-submit. |
yjbanov
reviewed
Jan 27, 2025
| if (pullRequest.user!.login == config.autosubmitBot && | ||
| pullRequest.labels!.any((element) => element.name == Config.revertOfLabel)) { | ||
| log.info('$logCrumb: skipping generating the full set of checks for revert request.'); | ||
| log.info('$logCrumb: skipping generating the full set of changes.'); |
Contributor
There was a problem hiding this comment.
This is not skipping "changes" though. It's skipping checks.
Contributor
Author
There was a problem hiding this comment.
This was a mistake on the part of John and I, we paired and vscode made some weird edits.
I'll send a PR fixing this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards flutter/flutter#162201.
If the following is true:
['jtmcdole', 'matanlurey', 'yjbanov'].contains(pullRequest.user!.login)DEPSnorengine/**sources... then we skip the entire engine build phase and the engine tests component of the tests phase.
If we like the outcome of this PR (after pushed, some manual testing), we can either open up the allow-list entirely or add additional names, and finally drop the allow-list entirely. Future work (i.e. expanding the file limit) need to be gated behind refactors and better test coverage, at least IMO.
Note this PR also regenerates
dart run build_runner buildsome generated files./cc @yjbanov