Add new gold shard names to Flutter Gold. #4172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
To be honest, I don't think so. A test would have not caught this issue, and adding a test would not catch a new issue. That is, there is sufficient coverage that this list of strings work for the intended purpose, and I don't think there is value to adding additional tests for different strings. |
jtmcdole
approved these changes
Jan 22, 2025
Contributor
|
Ok. The rest have tests. So if someone alters this list of strings and it gets dropped, I guess it gets dropped. 🤷♀️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shard was renamed in flutter/flutter#162020.