Skip to content

Match macOS and Xcode versions in framework repo #3993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
christopherfujino merged 3 commits into from
Oct 29, 2024
Merged

Match macOS and Xcode versions in framework repo #3993

christopherfujino merged 3 commits into from
Oct 29, 2024

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Oct 28, 2024 •
edited
Loading

Fixes flutter/flutter#157739

The Ruby builds purposely run in the devicelab, so the macOS and Xcode versions should match the framework devicelab builders.
flutter/flutter#157739 (comment)

@jmagman jmagman self-assigned this Oct 28, 2024
@jmagman jmagman changed the title Avoid running Mac builds in the devicelab Match macOS and Xcode versions in framework repo Oct 28, 2024
@jmagman
Copy link
Member Author

jmagman commented Oct 28, 2024 

Error: Xcode alone is not sufficient on Sonoma.
Install the Command Line Tools:
  xcode-select --install

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8732809658654453665/+/u/build_package/stdout

I guess cocoon recipe is missing some work that was done to support Xcode 15 cipd packages?

christopherfujino
christopherfujino approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino
Copy link
Contributor

christopherfujino commented Oct 29, 2024

Mac_arm64 ruby is failing for the same root cause as flutter/flutter#157814

@christopherfujino christopherfujino merged commit e790c54 into flutter:main Oct 29, 2024
@jmagman jmagman deleted the no-devicelab branch October 29, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Run cocoon Mac ruby builds on Xcode and macOS matching framework

2 participants

@jmagman @christopherfujino