Replace installation query with user-specific version #3710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of querying all installations and looking for the one owned by a specific user, use the endpoint that allows requesting the installation for a specific user. This avoids issues with pagination, as well as making the logic for processing the result simpler. Fixes flutter/flutter#148092
Contributor
christopherfujino
left a comment
There was a problem hiding this comment.
This looks fine, but I'll leave approval to Jason
jason-simmons
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of querying all installations and looking for the one owned by a specific user, use the endpoint that allows requesting the installation for a specific user. This avoids issues with pagination, as well as making the logic for processing the result simpler.
Fixes flutter/flutter#148092
Pre-launch Checklist
///).