Adds skia gold to engine release branches. #3659
Conversation
Piinks
left a comment
There was a problem hiding this comment.
Looks like CI failure is just the autoformatter check.
| final String defaultBranch = Config.defaultBranch(slug); | ||
| if (pr.base!.ref != defaultBranch) { | ||
| log.fine('This change is not staged to land on $defaultBranch, skipping.'); | ||
| if (!Config.doesSkiaGoldRunOnBranch(slug, pr.base!.ref)) { |
There was a problem hiding this comment.
When someone is working on a release branch, and the golden test fails, blocking a change from landing, how do they resolve it?
And has this been communicated to the team so folks know what to do?
There was a problem hiding this comment.
When someone is working on a release branch, and the golden test fails, blocking a change from landing, how do they resolve it?
If a cherry-pick on a release branch breaks a golden test, fixing that would depend on why it was broken. It could mean:
- An intermediate cherry-pick is missing and needs to also be merged in
- It's an integration problem where a fix would have to be devised:
- decide not to cherry-pick
- author a PR for the release branch
- author a PR on the main branch and cherry-pick on the release branch
And has this been communicated to the team so folks know what to do?
Yep, there was design doc that was worked on with the infra team: go/flutter-engine-goldens-workflow, there is also the documentation I linked in the PR description. The linked issue will be the basis for more concrete instructions once we've connected all the dots.
There was a problem hiding this comment.
SGTM! Thanks for the references. If anyone comes my way I'll direct them there!
|
I'm not sure how to resolve this. CI is complaining because |
Piinks
left a comment
There was a problem hiding this comment.
LGTM
cc @keyonghan may know how to resolve the googleapis issue.
| final String defaultBranch = Config.defaultBranch(slug); | ||
| if (pr.base!.ref != defaultBranch) { | ||
| log.fine('This change is not staged to land on $defaultBranch, skipping.'); | ||
| if (!Config.doesSkiaGoldRunOnBranch(slug, pr.base!.ref)) { |
There was a problem hiding this comment.
SGTM! Thanks for the references. If anyone comes my way I'll direct them there!
|
Seems latest push failed with format error. To unblock: cocoon is using line-length 120: https://github.com/flutter/cocoon/blob/main/format.sh#L8 |
issue: flutter/flutter#146078
This starts running skia gold bot checks on release branches for the engine. This works for the engine because our infrastructure forks all gold tests when a release branch is created.
See also:
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.