Skip to content

[app_dart] Refactor server to run locally #3364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 5 commits into from
Jan 3, 2024
Merged

[app_dart] Refactor server to run locally #3364

auto-submit merged 5 commits into from
Jan 3, 2024

Conversation

@CaseyHillers
Copy link
Contributor

@CaseyHillers CaseyHillers commented Dec 20, 2023

Fixes flutter/flutter#129651

  • There's various issues with running the appengine context locally, and I seem to lack permissions
  • This refactors most of the routing logic into lib, which verifies there's no breakages in this block of code

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read the [Flutter Style Guide] recently, and have followed its advice.
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

drewroengoogle
drewroengoogle approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@drewroengoogle drewroengoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM! Added a question for my understanding, and it looks like server.dart needs to be formatted.

@CaseyHillers CaseyHillers added the autosubmit Merge PR when tree becomes green via auto submit App. label Jan 3, 2024
@auto-submit auto-submit bot merged commit ce8e4c1 into flutter:main Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keyonghan keyonghan Awaiting requested review from keyonghan

1 more reviewer

@drewroengoogle drewroengoogle drewroengoogle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Local Cocoon servers fail with "Failed host lookup: 'metadata.google.internal'"

2 participants

@CaseyHillers @drewroengoogle