Skip to content

Run tests on either macOS 12 or macOS 13 #3136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 3 commits into from
Oct 10, 2023
Merged

Run tests on either macOS 12 or macOS 13 #3136

auto-submit merged 3 commits into from
Oct 10, 2023

Conversation

@vashworth
Copy link
Contributor

@vashworth vashworth commented Oct 10, 2023 •
edited
Loading

In preparation for migrating our fleet to macOS 13, we're updating tests to run on either macOS 12 or macOS 13.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@vashworth vashworth changed the title Run tests on either macOS 13 or macOS 13 Run tests on either macOS 12 or macOS 13 Oct 10, 2023
@vashworth vashworth mentioned this pull request Oct 10, 2023
Closed
17 tasks
@vashworth vashworth marked this pull request as ready for review October 10, 2023 19:13
@vashworth vashworth requested a review from keyonghan October 10, 2023 19:14
vashworth
vashworth commented Oct 10, 2023
View reviewed changes
keyonghan
keyonghan approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vashworth vashworth added the autosubmit Merge PR when tree becomes green via auto submit App. label Oct 10, 2023
@auto-submit auto-submit bot merged commit afe0388 into flutter:main Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@keyonghan keyonghan keyonghan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vashworth @keyonghan