Skip to content

Update source-uri. #3009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Aug 26, 2023
Merged

Update source-uri. #3009

auto-submit merged 1 commit into from
Aug 26, 2023

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Aug 26, 2023

The provenance generated by cloudbuild is now including https://git+.

Bug: flutter/flutter#133376

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Update source-uri.
1a5d402 
The provenance generated by cloudbuild is now including https://git+.

Bug: flutter/flutter#133376
@godofredoc godofredoc mentioned this pull request Aug 26, 2023
Merged
yusuf-goog
yusuf-goog approved these changes Aug 26, 2023
View reviewed changes
Copy link
Contributor

@yusuf-goog yusuf-goog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question... otherwise LGTM

cloud_build/verify_provenance.sh
PROVENANCE_PATH=$1
BUILDER_ID=https://cloudbuild.googleapis.com/GoogleHostedWorker@v0.3
SOURCE_URI=https://github.com/flutter/cocoon
SOURCE_URI=https://git+https://github.com/flutter/cocoon
Copy link
Contributor

@yusuf-goog yusuf-goog Aug 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the https:// prefix need to be removed?

Copy link
Contributor Author

@godofredoc godofredoc Aug 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, for some reason cloud build is adding that weird URI to the provenance.

@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App. label Aug 26, 2023
@auto-submit auto-submit bot merged commit 36a179c into flutter:main Aug 26, 2023
@godofredoc godofredoc deleted the fix_provenance branch August 26, 2023 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@yusuf-goog yusuf-goog yusuf-goog approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@godofredoc @yusuf-goog