Skip to content

Conversation

@ricardoamador
Copy link
Contributor

@ricardoamador ricardoamador commented Jun 21, 2023

When requests are made to the webhook_subscription there is one method that when called is disposing of the github client. In the _checkForTests methods it calls dispose on the github client which closes the connection while it is still in scope. This is the only part of the code that does this. This was killing the client for any pull request event for edited, opened, and reopened but not synchronized.

The fix will be investigated further but this prevents .ci.yaml checks and other issues blocking checkRuns from starting.

List which issues are fixed by this PR. You must list at least one issue.
Fixes: flutter/flutter#129134

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ricardoamador ricardoamador requested a review from keyonghan June 21, 2023 17:43
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardoamador ricardoamador added the autosubmit Merge PR when tree becomes green via auto submit App. label Jun 21, 2023
@auto-submit auto-submit bot merged commit ba9cf9b into flutter:main Jun 21, 2023
@ricardoamador ricardoamador deleted the fix_client_issue branch July 6, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci.yaml validation is stuck as pending on all PRs

2 participants