Do not dispose of the client in test check #2854
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When requests are made to the webhook_subscription there is one method that when called is disposing of the github client. In the _checkForTests methods it calls dispose on the github client which closes the connection while it is still in scope. This is the only part of the code that does this. This was killing the client for any pull request event for edited, opened, and reopened but not synchronized.
The fix will be investigated further but this prevents .ci.yaml checks and other issues blocking checkRuns from starting.
List which issues are fixed by this PR. You must list at least one issue.
Fixes: flutter/flutter#129134
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.