Skip to content

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Jun 13, 2023

This removes the _FakeViewport from the build dashboard implementation. It was added in #741, and we think it's sole purpose was the preserve the 1D expectations of widgets in the framework like scrollbars and overscroll indicators. Since adding support for 2D in the framework, the framework has been updated so that the fake viewport should no longer be necessary.

All of the tests pass, so I think this is safe to remove now that the framework is 2D compatible.

This came up as a test failure in flutter/flutter#128812, where the function signature of getOffsetToReveal is being changed.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks Piinks changed the title [WIP] Remove fake viewport from dashboard Remove fake viewport from dashboard Jun 13, 2023
@Piinks Piinks requested a review from CaseyHillers June 13, 2023 22:20
@CaseyHillers CaseyHillers added the autosubmit Merge PR when tree becomes green via auto submit App. label Jun 13, 2023
@auto-submit auto-submit bot merged commit b66e42c into flutter:main Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants