Skip to content

Clean up logics related to xcode/runtime properties #2810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
May 25, 2023
Merged

Clean up logics related to xcode/runtime properties #2810

auto-submit merged 2 commits into from
May 25, 2023

Conversation

@keyonghan
Copy link
Contributor

@keyonghan keyonghan commented May 25, 2023

Now we are relying solely on $flutter/osx_sdk property for xcode related logics. The PR removes logics based on xcode or runtime properties.

Part of flutter/flutter#127534

@keyonghan keyonghan added the autosubmit Merge PR when tree becomes green via auto submit App. label May 25, 2023
@auto-submit auto-submit bot merged commit cc0e348 into flutter:main May 25, 2023
@keyonghan keyonghan mentioned this pull request May 25, 2023
Closed
14 tasks
@keyonghan keyonghan deleted the xcode_cleanup branch March 13, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ricardoamador ricardoamador Awaiting requested review from ricardoamador

@godofredoc godofredoc Awaiting requested review from godofredoc

1 more reviewer

@yusuf-goog yusuf-goog yusuf-goog approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@keyonghan @yusuf-goog