[codesign] remove metadata files for now #2758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christopherfujino
approved these changes
May 16, 2023
Contributor
christopherfujino
left a comment
There was a problem hiding this comment.
nit about removing try - finally, otherwise LGTM
christopherfujino
approved these changes
May 16, 2023
Contributor
christopherfujino
left a comment
There was a problem hiding this comment.
nit about removing try - finally, otherwise LGTM
Co-authored-by: Christopher Fujino <fujino@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove codesign metadata after parsing them.
Context: fix flutter/flutter#126705 by removing codesign metadata after parsing them. When flutter/flutter#126875 becomes ready, we could add back codesign metadata inside engine zips?
Sorry for the delay, was busy landing different cps during the day