Skip to content

[app_dart] Remove labeling logic #2687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Jun 6, 2023
Merged

[app_dart] Remove labeling logic #2687

auto-submit merged 1 commit into from
Jun 6, 2023

Conversation

@CaseyHillers
Copy link
Contributor

@CaseyHillers CaseyHillers commented May 4, 2023

Fixes flutter/flutter#126002

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read the [Flutter Style Guide] recently, and have followed its advice.
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@CaseyHillers CaseyHillers marked this pull request as ready for review June 5, 2023 14:47
@CaseyHillers CaseyHillers mentioned this pull request Jun 5, 2023
Closed
5 tasks
@CaseyHillers CaseyHillers requested a review from keyonghan June 6, 2023 17:52
keyonghan
keyonghan approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming the label action is working correctly.

@CaseyHillers CaseyHillers added the autosubmit Merge PR when tree becomes green via auto submit App. label Jun 6, 2023
@auto-submit auto-submit bot merged commit ed66de0 into flutter:main Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@keyonghan keyonghan keyonghan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate cocoon label code to github workflows

2 participants

@CaseyHillers @keyonghan