[dashboard] Use new Google Sign In button. #2601

ditman · 2023-04-07T23:08:12Z

This PR:

Renames the old SignInButton widget to UserSignIn. This was done because the old SignInButton did much more than rendering a button (it also rendered the "signed-in" status of the user).
Adds a new SignInButton widget, which has two variants:
- For native, it is the old implementation
- For web, it uses the new renderButton widget (this required adding two new "any" dependencies to pubspec)
Tweaks the authentication service a little bit (removed unused scopes, simplified some checks)
Fixes an issue where the top navbar wouldn't update after sign-in/sign-out. (Not sure if there's a github issue for this!)
Regenerates mockito mocks, and helps others do the same down the line :)
Tweaks to the index_page and sidebar.

Issues

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read the Flutter Style Guide recently, and have followed its advice.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

…command anymore.

ditman

Hello new sign-in button!

ditman · 2023-04-08T02:31:10Z

dashboard/lib/widgets/sign_in_button/sign_in_button_web.dart

+
+  @override
+  Widget build(BuildContext context) {
+    return (GoogleSignInPlatform.instance as GoogleSignInPlugin).renderButton();


We can tweak the looks of the button, see a configurable demo here:

https://dit-gis-button-test.web.app

ditman · 2023-04-08T02:32:28Z

dashboard/test/utils/mocks.mocks.dart

@@ -1,299 +1,800 @@
-// Mocks generated by Mockito 5.0.15 from annotations
+// Mocks generated by Mockito 5.4.0 from annotations


It's been a while! (August 2021)

ditman · 2023-04-08T02:33:46Z

dashboard/web/index.html

  <meta charset="UTF-8">
  <meta name="google-signin-client_id" content="308150028417-vlj9mqlm3gk1d03fb0efif1fu5nagdtt.apps.googleusercontent.com">
-  <title>Build Dashboard</title>
+  <title>Flutter Build Dashboard — Cocoon</title>


To improve SEO (for myself) :P

ditman · 2023-04-08T03:12:21Z

dashboard/test/utils/mocks.mocks.dart

I had to re-format this file after re-generating it (it seems mockito generates at 80 cols, but the repo is validating at 120). Please consider skipping *.mocks.dart from the formatting checks!

Alternatively, this could run dart format with the right parameters after mocks are regenerated :/

ricardoamador · 2023-04-08T15:31:10Z

Nice! Thanks for doing this David! If I can clone your branch I can do a test deploy before merging this.

dashboard/regen_mocks.sh

Use flutter pub get rather than dart. Co-authored-by: Casey Hillers <caseyhillers@gmail.com>

ditman · 2023-04-10T17:44:44Z

Nice! Thanks for doing this David! If I can clone your branch I can do a test deploy before merging this.

@ricardoamador you should be able to fetch from my remote and clone the branch, I think? I marked the checkbox of "collaborators can do whatever they want" while creating the PR (you should be even able to push to the branch if you want to!)

ricardoamador · 2023-04-10T17:55:20Z

Cool I will check it out. Validating now.

ricardoamador · 2023-04-10T20:25:35Z

Okay first run went like this:

Restarted application in 191ms.
[GSI_LOGGER-TOKEN_CLIENT]: Instantiated.
[GSI_LOGGER]: The given origin is not allowed for the given client ID.
[GSI_LOGGER]: Prompt will not be displayed
[google_sign_in_web] Error on CredentialResponse:
[google_sign_in_web] Removing error from `userDataEvents`:
[GSI_LOGGER]: Processing click for button: gsi_283171_880200.

Then it just hangs with the authentication pop up like this:

ditman · 2023-04-10T21:50:05Z

[GSI_LOGGER]: The given origin is not allowed for the given client ID.

@ricardoamador The new JS SDK requires localhost:8080 AND localhost as authorized javascript origins in the configuration of the Client ID:

When you perform local tests or development, you must add both http://localhost and http://localhost:<port_number> to the Authorized JavaScript origins box.

More info here: https://developers.google.com/identity/gsi/web/guides/get-google-api-clientid

(I bet you'd get this error if you tried to do the same test without any of my changes applied, just from the tip of master!)

ricardoamador · 2023-04-10T22:29:42Z

Okay validated the change and it now works with the google login.

ricardoamador

LGTM!

ditman · 2023-04-10T22:37:07Z

Thanks @CaseyHillers @ricardoamador for the super quick review!

ditman added 14 commits April 7, 2023 16:24

Rename SignInButton -> UserSignIn

6466eae

Depend on google_sign_in ^6.1.0

7542ff8

Rebase with rename classes

577eac5

Add sign_in_button widget, with native and web bits.

92ec164

Use the new SignInButton.

5fc8bcb

Re-render UserSignIn when authService.user changes.

63e8b99

Tighten padding around button.

09c40b7

Add missing license

56c84a3

Fix license.

6adb287

dart format

cc873c2

Regen mockito mocks, and add a script so we don't have to dig up the …

41b49ae

…command anymore.

Return a null user when isAuthenticated returns false.

ff88e65

Small, unsolicited, tweaks.

f0d247d

Help tests.

b2fa95c

ditman commented Apr 8, 2023

View reviewed changes

ditman added 4 commits April 7, 2023 19:36

Update license header.

0070607

Fix hashbang.

3d04970

Allow regen_mocks.sh to exist.

f9e13ef

dart format. SHOULDN'T LOOK AT mocks.dart!

1d20278

ditman marked this pull request as ready for review April 8, 2023 03:09

ditman mentioned this pull request Apr 8, 2023

Build dashboard sign in silently is failing flutter/flutter#121275

Closed

ditman requested review from CaseyHillers and ricardoamador April 8, 2023 03:10

ditman commented Apr 8, 2023

View reviewed changes

CaseyHillers approved these changes Apr 10, 2023

View reviewed changes

dashboard/regen_mocks.sh Outdated Show resolved Hide resolved

Update dashboard/regen_mocks.sh

1e282bd

Use flutter pub get rather than dart. Co-authored-by: Casey Hillers <caseyhillers@gmail.com>

ditman self-assigned this Apr 10, 2023

ditman mentioned this pull request Apr 10, 2023

[web] Google Sign In GIS SDK migration community support 🚑 flutter/flutter#124297

Closed

Stop using deprecated web config style.

a7baa62

ricardoamador approved these changes Apr 10, 2023

View reviewed changes

ditman added the autosubmit Merge PR when tree becomes green via auto submit App. label Apr 10, 2023

auto-submit bot merged commit 5e711dc into flutter:main Apr 10, 2023

ditman deleted the use-new-sign-in-button branch April 10, 2023 22:36

ditman mentioned this pull request Nov 20, 2023

signInSilently does not resolve on Web when using google_sign_in_web 0.12.1 flutter/flutter#138675

Closed

2 tasks

		@@ -1,299 +1,800 @@
		// Mocks generated by Mockito 5.0.15 from annotations
		// Mocks generated by Mockito 5.4.0 from annotations

[dashboard] Use new Google Sign In button. #2601

[dashboard] Use new Google Sign In button. #2601

Uh oh!

Conversation

ditman commented Apr 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issues

Pre-launch Checklist

Uh oh!

ditman left a comment

Choose a reason for hiding this comment

Uh oh!

ditman Apr 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ditman Apr 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ditman Apr 8, 2023

Choose a reason for hiding this comment

Uh oh!

ditman Apr 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ditman Apr 10, 2023

Choose a reason for hiding this comment

Uh oh!

ricardoamador commented Apr 8, 2023

Uh oh!

Uh oh!

ditman commented Apr 10, 2023

Uh oh!

ricardoamador commented Apr 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ricardoamador commented Apr 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ditman commented Apr 10, 2023

Uh oh!

ricardoamador commented Apr 10, 2023

Uh oh!

ricardoamador left a comment

Choose a reason for hiding this comment

Uh oh!

ditman commented Apr 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ditman commented Apr 7, 2023 •

edited

Loading

ditman Apr 8, 2023 •

edited

Loading

ditman Apr 8, 2023 •

edited

Loading

ditman Apr 8, 2023 •

edited

Loading

ricardoamador commented Apr 10, 2023 •

edited

Loading

ricardoamador commented Apr 10, 2023 •

edited

Loading