Update CI_YAML.MD regarding taget updates #2519
Conversation
| ``` | ||
| - Send PR, wait for the checks to go green (**the change takes effect on presubmit**) | ||
| 3. If the check is red, add patches to get it green | ||
| 4. Once the PR has landed, infrastructure may take 1 or 2 commits to apply the latest properties |
There was a problem hiding this comment.
I'm confused; it takes effect immediately for presubmit, but not for postsubmit? So property changes still can't be landed in the same PR as changes that require them (like removing bring up)?
Or is this not the case for properties?
There was a problem hiding this comment.
Good point. Properties should take effect immediately for both presubmit and postsubmit. Now we are on cocoon scheduling, which fetches latest properties and use them to schedule builds. Updated.
There was a problem hiding this comment.
So item 4 here should be removed, right?
There was a problem hiding this comment.
We still need it. The properties will be seen by the current PR/commit immediately, but there are cases where we need to wait, such incoming PRs/commits, which haven't rebased on top of that changing PR, and local LED runs.
Expanded a bit. Please let me know if this makes sense to you.
There was a problem hiding this comment.
Another case is caches. While dependencies can be upgraded, there may be some slow downs on the initial roll out due to cache invalidation
There was a problem hiding this comment.
Added one more item to cover.
Suppose we have a property change PR (pr1) and an incoming PR (pr2): Yeah, this is some backend infra logics:-) |
Wait, so does the infra behavior distinguish between "the state of .ci.yaml in the PR" and "the changes to .ci.yaml in the PR". I.e., looking at deltas in the PR specifically? |
That's correct. If no changes in |
Following flutter/flutter#120912 (comment) to make doc clear.