Skip to content

Objective-C integration and unit tests do not need tests #2063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Aug 19, 2022
Merged

Objective-C integration and unit tests do not need tests #2063

auto-submit merged 2 commits into from
Aug 19, 2022

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Aug 18, 2022

iOS and macOS native unit and integration tests should count as a PR having tests.

Fixes flutter/flutter#109788

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman self-assigned this Aug 18, 2022
@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App. label Aug 19, 2022
@auto-submit auto-submit bot merged commit 6a4b49d into flutter:main Aug 19, 2022
@jmagman jmagman mentioned this pull request Aug 19, 2022
Merged
8 tasks
@jmagman jmagman deleted the objc-tests branch September 23, 2022 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christopherfujino christopherfujino Awaiting requested review from christopherfujino

1 more reviewer

@CaseyHillers CaseyHillers CaseyHillers approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

autosubmit Merge PR when tree becomes green via auto submit App.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[flutter/flutter] The XCUITest in flutter repo is not recognized as test files

2 participants

@jmagman @CaseyHillers